20196 Added some fallbacks to prevent invalid JSON

severinbeauvais commented 8 months ago

Issue #: bcgov/entity#20196

Description of changes:

app version = 5.9.9
cleaned up some code
added fallback (to empty string) for business email to all filings
added fallback (to empty string) for business phone to all filings
don't initialize isBusinessLookup when fetching directors (ie, leave it undefined)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 8 months ago

/gcbrun

bcregistry-sre commented 8 months ago

Temporary Url for review: https://business-create-dev--pr-666-q0tfjm9b.web.app

SB says, try this: https://business-create-dev--pr-666-q0tfjm9b.web.app/amalg-short-information?id=TNouW8zN0T&accountid=2079

you can file it, but then don't pay for it, and return to business dashboard and cancel the payment so that it returns to Draft state

bcgov / business-create-ui

20196 Added some fallbacks to prevent invalid JSON #666