16606 Added invalid NR dialog

severinbeauvais commented 6 months ago

Issue #: bcgov/entity#16606

Description of changes:

Commit 1:

app version = 5.9.10
imported latest shared CorrectName component
imported latest shared mixins
renamed NameRequestInvalidErrorDialog -> InvalidIncorpAppDialog
added dialog to ResultingBusinessName
added dialog to BusinessName
added missing parameters to validate method in BusinessName
created NameRequestErrorDialog
created unit test suite
misc cleanup

Commit 2:

imported latest shared correct-name component
import latest shared mixins
renamed InvalidIncorpAppDialog -> InvalidFilingDialog
renamed InvalidFilingDialog -> FilingNotExistDialog
imported misc enums directly from shared repo
used Name Request Error dialog for File and Pay fetch error
after File and Pay NR error, leave user in Create UI
cleaned up NR processing in App.vue
added NR action code check in App.vue
on resume, check if NR is consumable after storing it
moved fetch error logic from service to to components
cleaned up NR processing in Actions.vue
generalized the text in File and Pay NR dialog
added spacer to move dialog button to right side
fixed misc dialog styling
updated unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://business-create-dev--pr-670-2rb2r2k2.web.app

SB says, try these with the NR below (or any other):

Regular amalgamation: https://business-create-dev--pr-670-2rb2r2k2.web.app/amalg-reg-information?id=T9uQLHw9ma
Restoration: https://business-create-dev--pr-670-2rb2r2k2.web.app/restoration-business-name?id=BC0872779

Sample registration with expired NR: https://business-create-dev--pr-670-2rb2r2k2.web.app/registration-define-business?id=TOQ52ZIGkK

Sample IA with valid NR: https://business-create-dev--pr-670-2rb2r2k2.web.app/incorporation-define-company?id=TBv5Dc0hRP

(See ticket for misc screenshots.)

bcgov / business-create-ui

16606 Added invalid NR dialog #670