20489 Misc cleanup - Githubissues

bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application

Apache License 2.0

7 stars 48 forks source link

20489 Misc cleanup #674

Closed severinbeauvais closed 6 months ago

severinbeauvais commented 6 months ago

Issue #: bcgov/entity#20489

Description of changes:

app version = 5.9.11
saved correct name option for other filings (not used but denotes code intent for future debugging/audit)
updated unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 6 months ago

/gcbrun

bcregistry-sre commented 6 months ago

Temporary Url for review: https://business-create-dev--pr-674-dprzede5.web.app

severinbeauvais commented 6 months ago

There's a mismatch between ticket name and PR 😆

Thanks for checking that. Yes, here I go back to Create UI to clean up something I noticed while comparing with other filings and with Edit UI.

severinbeauvais commented 6 months ago

PS There's still an issue uploading coverage to CodeCov but the tests pass fine locally and even here.

Locally:

The "Test with Vitest" step passed:

JazzarKarim commented 6 months ago

PS There's still an issue uploading coverage to CodeCov but the tests pass fine locally and even here.

Yup, been having this issue as well in my PRs. All good.