20989 - Implement manual business entry

bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application

Apache License 2.0

7 stars 48 forks source link

20989 - Implement manual business entry #684

Closed ketaki-deodhar closed 5 months ago

ketaki-deodhar commented 6 months ago

Issue #: /bcgov/entity#20989

Description of changes:

Based on some business decisions this design might change but pushing this code so that if we ever want to revert back, to this code is partially ready.

Implement Jurisdiction component
Display form based on MRAS/ Non MRAS jurisdiction
Implement Manual Business information

Select Jurisdiction:

Non MRAS:

Validations:

All fields entered:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 5 months ago

Did you verify the review and confirm page? Looks OK to me but I didn't test everything:

ketaki-deodhar commented 5 months ago

Did you verify the review and confirm page? Looks OK to me but I didn't test everything:

Yes. I verified

ketaki-deodhar commented 5 months ago

This component doesn't initialize correctly. You can see this by "undoing" the lookup option, or undoing all options and saving and resuming.

Currently, this is the initial state of this component:

It should be:

Looking ....

severinbeauvais commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://business-create-dev--pr-684-c6w4g4zv.web.app

SB says, try this: https://business-create-dev--pr-684-c6w4g4zv.web.app/continuation-in-business-home?id=TZDikc3p6I