19266 - Plugged in Company Name Component

bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application

Apache License 2.0

7 stars 48 forks source link

19266 - Plugged in Company Name Component #687

Closed ArwenQin closed 5 months ago

ArwenQin commented 6 months ago

Issue #: /bcgov/entity#

Description of changes:

Added the Company Name component
Validated NR type/state/etc
Verified support for named or numbered continuation in
Verified Save and Resume Later

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 5 months ago

PS In a couple of weeks, I will give you extra repo permissions so you can assign suitable reviewers yourself. In the meantime, Ketaki or I can do it for you.

severinbeauvais commented 5 months ago

PPS The "testing-coverage" check fails at the "Upload coverage to Codecov" step. This isn't your fault; there are changes under way to get this working correctly again. But do verify that the previous step, "Test with Vitest", passed.

severinbeauvais commented 5 months ago

You should not have to close a PR and open a new one. Next time you think this is needed, contact me and I'll show you how to rebase/push things correctly :)