19266 - Plugged in Company Name Component

bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application

Apache License 2.0

7 stars 47 forks source link

19266 - Plugged in Company Name Component #688

Closed ArwenQin closed 4 months ago

ArwenQin commented 4 months ago

Issue #: /bcgov/entity#19266

Description of changes:

Added the Company Name component
Validated NR type/state/etc
Verified support for named or numbered continuation in
Verified Save and Resume Later

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

ketaki-deodhar commented 4 months ago

Sev' comment on other PR

Before your PR is ready for review...

update the app version in the package.json file (you can update the patch version for this PR)
run npm i and also commit the package-lock.json file
run npm run lint and fix any new issues
run npm run test:unit and fix any issues (there should be no previous issues)
in a PR comment, enter /gcbrun, which builds a preview site (URL) with your changes that reviews can run and test with
change this PR to "Ready for review"

severinbeauvais commented 4 months ago

I think you need to add something to the validation for step 2 (Your Business in B.C.) -- even though I have filled everything in, the review page says that step 2 is unfinished.

Hint: start from the review page to see what it looks at to determine that step 2 is invalid. Then go to step or the store to update whatever is needed so the step is valid when all components on it are valid.

ArwenQin commented 4 months ago

Have you tested this with a named continuation in application (ie, one that uses a NR to set a company name)?

I think you need to add something to the validation for step 2 (Your Business in B.C.) -- even though I have filled everything in, the review page says that step 2 is unfinished.

Hint: start from the review page to see what it looks at to determine that step 2 is invalid. Then go to step or the store to update whatever is needed so the step is valid when all components on it are valid.

Hi Severin, @severinbeauvais , It's an issue with the DefineCompanyStepValidity. I updated the ContinuationInBusinessBc.vue file to fix this issue. I added the getter to update the DefineCompanyStepValidity.

severinbeauvais commented 4 months ago

Looks great so far!

Please finish the unit tests for this page (see ContinuationInBusinessBc.spec.ts).

PS In VS Code, you can search for files by name using Ctrl-P.

severinbeauvais commented 4 months ago

/gcbrun

bcregistry-sre commented 4 months ago

Temporary Url for review: https://business-create-dev--pr-688-fyq5ge7j.web.app

SB says, try these:

severinbeauvais commented 4 months ago

Code looks good. Works nicely on preview URLs above. Just the following:

[ ] check in package-lock.json
[ ] update unit tests

ArwenQin commented 4 months ago

Code looks good. Works nicely on preview URLs above. Just the following:

[ ] check in package-lock.json

[ ] update unit tests

Thank you so much. I just updated the unit tests and checked in the package-lock.json

ArwenQin commented 4 months ago

permission to Squash and Merge it

Thanks Severin. But it seems I don't have write access to merge pull yet.