bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application
Apache License 2.0
7 stars 47 forks source link

21138 Fetch and display expro data from COLIN + UI updates + fixed misc states and validations, etc #691

Closed severinbeauvais closed 3 months ago

severinbeauvais commented 4 months ago

Issue #: bcgov/entity#21138

Description of changes: Commit 1:

Commit 2:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 3 months ago

/gcbrun

bcregistry-sre commented 3 months ago

Temporary Url for review: https://business-create-dev--pr-691-nozaqqyw.web.app

SB says, try these: C (with no data entered): https://business-create-dev--pr-691-nozaqqyw.web.app/continuation-in-business-home?id=TItNIA7UFN CBEN: https://business-create-dev--pr-691-nozaqqyw.web.app/continuation-in-business-home?id=TbY9bJGz0k CUL: https://business-create-dev--pr-691-nozaqqyw.web.app/continuation-in-business-home?id=TyS39DGw5j

Search for active expro: A0073450 Search for active expro: A0071234 (different name in BC/SK) Search for active expro: A0045632 (missing name in home jurisdiction) Search for historical expro (Alberta): A0034510 Search for historical expro (Federal): A0014545

JazzarKarim commented 3 months ago

I've tested a bunch in the temp links, it's amazing we're getting all these details from that COLIN call: colin call returning

This helps a bunch.

severinbeauvais commented 3 months ago

I've tested a bunch in the temp links, it's amazing we're getting all these details from that COLIN call: ...

Thanks for testing! Yes, Vysakh and I designed this COLIN call and he implemented it 😀

(We did this so that Business Search didn't have to be updated.)