21315 - Upload Director's Affidavit

bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application

Apache License 2.0

7 stars 48 forks source link

21315 - Upload Director's Affidavit #696

Closed ArwenQin closed 5 months ago

ArwenQin commented 5 months ago

Issue #: /bcgov/entity#21315

Description of changes:

Added Upload Director's Affidavit component for manual input

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

ArwenQin commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://business-create-dev--pr-696-latq0hhi.web.app

SB says, try this: https://business-create-dev--pr-696-latq0hhi.web.app/continuation-in-business-home?id=TyS39DGw5j

severinbeauvais commented 5 months ago

There should be extra whitespace above the Important message box (mt-6).

ArwenQin commented 5 months ago

There should be extra whitespace above the Important message box (mt-6).

Updated

ArwenQin commented 5 months ago

Looks great!

However, since this is a duplicate of the code in ExtraproRegistration.vue, can you please extract it into a new sub-component, and use that sub-component in both components?

Also, please add some basic unit tests for the new sub-component, and also update ExtraproRegistration.spec.ts and create ManualBusinessInfo.spec.ts.

Thanks!

I added the UploadAffidavit.vue sub-component. I will add the unit tests tmr.

ArwenQin commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://business-create-dev--pr-696-latq0hhi.web.app