21315 - Upload Director's Affidavit

bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application

Apache License 2.0

7 stars 47 forks source link

21315 - Upload Director's Affidavit #697

Closed ArwenQin closed 3 months ago

ArwenQin commented 3 months ago

Issue #: /bcgov/entity#21315

Description of changes:

Added Upload Director's Affidavit component for manual input
Restructured code, added a new sub-component UploadAffidavit

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

ArwenQin commented 3 months ago

/gcbrun

ArwenQin commented 3 months ago

I will add unit tests. - Added

bcregistry-sre commented 3 months ago

Temporary Url for review: https://business-create-dev--pr-697-tnyj58ql.web.app

SB says, try this: https://business-create-dev--pr-697-tnyj58ql.web.app/continuation-in-business-home?id=TyS39DGw5j

ArwenQin commented 3 months ago

/gcbrun

bcregistry-sre commented 3 months ago

Temporary Url for review: https://business-create-dev--pr-697-tnyj58ql.web.app

ArwenQin commented 3 months ago

Looks great. Very clean :)

I'm approving now as I'm leaving early today. I trust you to update some unit tests. Wait for another approval and then this PR can be merged.

Thank you. Unit tests are added.

ArwenQin commented 3 months ago

/gcbrun

bcregistry-sre commented 3 months ago

Temporary Url for review: https://business-create-dev--pr-697-tnyj58ql.web.app