21599 - Updated Step One Tick Mark Issue

bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application

Apache License 2.0

7 stars 48 forks source link

21599 - Updated Step One Tick Mark Issue #705

Closed ArwenQin closed 5 months ago

ArwenQin commented 5 months ago

Issue #: /bcgov/entity#21599

Description of changes:

Step one will only show the Tick Mark and errors, after the user visits the Review and Confirm Page
The authorization date picker will reset, if the incorporation date is changes to a date after the current selected authorization date. (Otherwise the component will be valid regardless of the invalid authorization date)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

ArwenQin commented 5 months ago

I updated the ContinuationInAuthorization component - The authorization date picker will reset, if the incorporation date changes to a date after the current selected authorization date. Otherwise the component will be valid regardless of the invalid authorization date, current:

ArwenQin commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://business-create-dev--pr-705-mufawei3.web.app

severinbeauvais commented 5 months ago

I updated the ContinuationInAuthorization component - The authorization date picker will reset, if the incorporation date changes to a date after the current selected authorization date. Otherwise the component will be valid regardless of the invalid authorization date

~I don't think the ManualBusinessInfo component should change another component's object.~ My mistake, I read your comment before I looked at your code. This isn't an issue.

You can probably make the original code work properly by checking the form validity in ContinuationAuthorization.vue::onComponentValid() (and maybe you need a variable for form validity and you need to watch it, same as here).

ArwenQin commented 5 months ago

/gcbrun

ArwenQin commented 5 months ago

I updated the ContinuationInAuthorization component - The authorization date picker will reset, if the incorporation date changes to a date after the current selected authorization date. Otherwise the component will be valid regardless of the invalid authorization date

~I don't think the ManualBusinessInfo component should change another component's object.~ My mistake, I read your comment before I looked at your code. This isn't an issue.

You can probably make the original code work properly by checking the form validity in ContinuationAuthorization.vue::onComponentValid() (and maybe you need a variable for form validity and you need to watch it, same as here).

Got it, thanks! I updated the coding, much simpler now. Will re-validate the component when the minAuthoDate changes.

bcregistry-sre commented 5 months ago

Temporary Url for review: https://business-create-dev--pr-705-mufawei3.web.app

ArwenQin commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://business-create-dev--pr-705-mufawei3.web.app

bcregistry-sre commented 5 months ago

Temporary Url for review: https://business-create-dev--pr-705-mufawei3.web.app

bcregistry-sre commented 5 months ago

Temporary Url for review: https://business-create-dev--pr-705-mufawei3.web.app

ArwenQin commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://business-create-dev--pr-705-mufawei3.web.app

severinbeauvais commented 5 months ago

@ArwenQin , thanks for all your testing and trying things, and pushing back when I was missing something key. Together, we got this! :)