search

bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application
Apache License 2.0
7 stars 48 forks source link

21110 Deleted documents that were cleared by user #707

Closed severinbeauvais closed 5 months ago

severinbeauvais commented 5 months ago

Issue #: bcgov/entity#21110

This is part 1 of the ticket (when user clears an uploaded file). Part 2 will be in a separate PR. Unfortunately this isn't testable at the moment because the Legal API endpoint doesn't exist, but it can be verified that this code change doesn't break anything. I will test when I work on part 2.

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 5 months ago

/gcbrun

bcregistry-sre commented 5 months ago

Temporary Url for review: https://business-create-dev--pr-707-jgs4u8b5.web.app

severinbeauvais commented 5 months ago

This is what happens if you clear (click X on) an uploaded files. Note that is not a CORS error -- it's the Legal API not handling this call. There is no indication to the user that this didn't work (they won't care anyway). Only this console error:

image