21894 Added LTD to CCC numbered name

bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application

Apache License 2.0

7 stars 47 forks source link

21894 Added LTD to CCC numbered name #714

Closed severinbeauvais closed 3 months ago

severinbeauvais commented 3 months ago

Issue #: bcgov/entity#21894

Description of changes:

app version = 5.11.3
imported latest correct-name shared component
added CCC and CUL to numbered company suffix logic (2 places)
added "LTD." to CCC numbered name (2 places)
pass entity type to CorrectName so it can correctly show numbered name
updated/added unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 3 months ago

/gcbrun

bcregistry-sre commented 3 months ago

Temporary Url for review: https://business-create-dev--pr-714-h6xcnwha.web.app

SB says, try these:

Numbered IA in Dev: https://dev.create.business.bcregistry.gov.bc.ca/incorporation-define-company?id=TxR8r6ykkX Numbered IA in PR: https://business-create-dev--pr-714-h6xcnwha.web.app/incorporation-define-company?id=TxR8r6ykkX

Numbered Amalgamation in Dev: https://dev.create.business.bcregistry.gov.bc.ca/amalg-reg-information?id=TIDMMJW1jX& Numbered Amalgamation in PR: https://business-create-dev--pr-714-h6xcnwha.web.app/amalg-reg-information?id=TIDMMJW1jX&

Numbered Continuation In in Dev: https://dev.create.business.bcregistry.gov.bc.ca/continuation-in-business-bc?id=T72KyDo2x2 Numbered Continuation In in PR: https://business-create-dev--pr-714-h6xcnwha.web.app/continuation-in-business-bc?id=T72KyDo2x2

severinbeauvais commented 3 months ago

I made an additional fix because I noticed that changing the amalgamation resulting business name to numbered wasn't working for a CCC. This is because the entity type was not being passed to the shared CorrectName component, so it could not compute the new name.