Fix-19483-Amalg/ContIn-Singular-Grammar

bcgov / business-create-ui

BC Registry Services - Legal Entities - Create Incorporation Application

Apache License 2.0

7 stars 47 forks source link

Fix-19483-Amalg/ContIn-Singular-Grammar #719

Closed ArwenQin closed 2 months ago

ArwenQin commented 2 months ago

Issue #: /bcgov/entity#19483

Description of changes:

Changed the word "businesses" from Plural to Singular, now: "... Office Mailing and Delivery Addresses of the resulting business..." for Amalg and ContIn

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

bcregistry-sre commented 2 months ago

Temporary Url for review: https://business-create-dev--pr-719-wmhodmh0.web.app

severinbeauvais commented 2 months ago

I think you should also update the app version so that you can track this fix through the environments. Ie, with a new version number, you would be able to confirm that your code change is deployed:

ArwenQin commented 2 months ago

Is a fix also needed in ContinuationInBusinessBc.vue?

Thank you (Sorry I missed this). Updated ContIn and the version number now.

ArwenQin commented 2 months ago

/gcbrun

bcregistry-sre commented 2 months ago

Temporary Url for review: https://business-create-dev--pr-719-wmhodmh0.web.app