bcgov / business-edit-ui

BC Registry Services - Legal Entities - Edit Incorporation Application (correction, alteration)
Apache License 2.0
3 stars 44 forks source link

16226 CorrectName cleanup + updated packages #498

Closed severinbeauvais closed 1 year ago

severinbeauvais commented 1 year ago

Issue #: bcgov/entity#16226

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

codecov[bot] commented 1 year ago

Codecov Report

Merging #498 (5332263) into main (ae09408) will decrease coverage by 0.77%. The diff coverage is 91.92%.

@@            Coverage Diff             @@
##             main     #498      +/-   ##
==========================================
- Coverage   86.96%   86.19%   -0.77%     
==========================================
  Files         195      192       -3     
  Lines        3645     3536     -109     
  Branches      444      442       -2     
==========================================
- Hits         3170     3048     -122     
- Misses        462      474      +12     
- Partials       13       14       +1     
Impacted Files Coverage Δ
...ents/SpecialResolution/CreateSpecialResolution.vue 100.00% <ø> (ø)
src/components/common/Detail.vue 100.00% <ø> (ø)
src/components/common/EffectiveDateTime.vue 100.00% <ø> (ø)
...omponents/common/PeopleAndRoles/PeopleAndRoles.vue 100.00% <ø> (ø)
src/components/common/YourCompany/index.ts 100.00% <ø> (ø)
src/dialogs/FetchErrorDialog.vue 100.00% <ø> (ø)
src/dialogs/FileAndPayInvalidNameRequestDialog.vue 100.00% <ø> (ø)
src/dialogs/PaymentErrorDialog.vue 100.00% <ø> (ø)
src/dialogs/SaveErrorDialog.vue 100.00% <ø> (ø)
...erfaces/state-interfaces/name-request-interface.ts 100.00% <ø> (ø)
... and 70 more

... and 2 files with indirect coverage changes

severinbeauvais commented 1 year ago

Please review but do not merge -- I'm investigating a weird issue with the extension time.

Localhost: image

Dev: image