13021 - Special Resolution

[seeker25]

Issue #: bcgov/entity#13021

Description of changes: Changes to support Special Resolution filing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

[codecov[bot]]

Codecov Report

Merging #499 (de0bbcf) into main (ae09408) will decrease coverage by 1.30%. The diff coverage is 82.26%.

@@            Coverage Diff             @@
##             main     #499      +/-   ##
==========================================
- Coverage   86.96%   85.67%   -1.30%     
==========================================
  Files         195      202       +7     
  Lines        3645     3762     +117     
  Branches      444      473      +29     
==========================================
+ Hits         3170     3223      +53     
- Misses        462      525      +63     
- Partials       13       14       +1     

Impacted Files	Coverage Δ
src/components/common/Detail.vue	100.00% <ø> (ø)
src/components/common/EffectiveDateTime.vue	100.00% <ø> (ø)
...omponents/common/PeopleAndRoles/PeopleAndRoles.vue	100.00% <ø> (ø)
src/components/common/YourCompany/index.ts	100.00% <ø> (ø)
src/dialogs/FetchErrorDialog.vue	100.00% <ø> (ø)
src/dialogs/FileAndPayInvalidNameRequestDialog.vue	100.00% <ø> (ø)
src/dialogs/PaymentErrorDialog.vue	100.00% <ø> (ø)
src/dialogs/SaveErrorDialog.vue	100.00% <ø> (ø)
...erfaces/state-interfaces/name-request-interface.ts	100.00% <ø> (ø)
src/resources/LimitedRestorationExtension/BC.ts	100.00% <ø> (ø)
... and 86 more

[seeker25]

To go - fix unit test (just busted it by accident), Paper scenarios (there are unit tests, but the UX might need some help - not easily testable, because our IA always requires a PDF):

[severinbeauvais]

~I'm not sure what's going on with GH right now but I am unable to add single comments. Obviously this is impacting my ability to review this. Will reboot later and try again.~ working again

[seeker25]

Tech debt ticket: https://github.com/bcgov/entity/issues/16489

[severinbeauvais]

Would be nice to get some other review approvals (otherwise I'm the code gatekeeper, and that's a team role).

[seeker25]

Just fixing the paper draft issue Severin pointed out

[seeker25]

I've made some minor changes. I'm seeing another problem unrelated to this commit. The time it takes for npm run serve to run.. or npm run build seems to be fairly high. For example below an 8 minute build check (#499 this PR).

It was 4 minutes on this PR: https://github.com/bcgov/business-edit-ui/pull/497 https://github.com/bcgov/business-edit-ui/actions/runs/4867695121/jobs/8680505760

7 minutes: https://github.com/bcgov/business-edit-ui/pull/498 https://github.com/bcgov/business-edit-ui/actions/runs/5062176499/jobs/9087370052

[seeker25]

Merging, if you see any issues - can address it in another PR.

[severinbeauvais]

I've made some minor changes. I'm seeing another problem unrelated to this commit. The time it takes for npm run serve to run.. or npm run build seems to be fairly high...

I wouldn't rely too much on GH build times, but I have noticed builds taking longer locally -- ever since the new packages, I think. Sometimes I think my WSL VM runs out of memory, too. I'll keep an eye out but I haven't found what it is, yet. (I wouldn't mind trying out Vite, though.)

[seeker25]

This PR has changes in it that freeze up the type checking:

https://github.com/bcgov/business-edit-ui/pull/498

I've tried the PR before it and don't have the same issues:

https://github.com/bcgov/business-edit-ui/pull/497