bcgov / business-edit-ui

BC Registry Services - Legal Entities - Edit Incorporation Application (correction, alteration)
Apache License 2.0
3 stars 44 forks source link

16444 Use Keycloak roles for LaunchDarkly update #501

Closed severinbeauvais closed 1 year ago

severinbeauvais commented 1 year ago

Issue #: bcgov/entity#16444

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 1 year ago

What this looks like in LaunchDarkly (with my IDIR):

image

With BCREG0020:

image

codecov[bot] commented 1 year ago

Codecov Report

Merging #501 (b99a189) into main (ae09408) will decrease coverage by 1.22%. The diff coverage is 82.71%.

@@            Coverage Diff             @@
##             main     #501      +/-   ##
==========================================
- Coverage   86.96%   85.75%   -1.22%     
==========================================
  Files         195      202       +7     
  Lines        3645     3749     +104     
  Branches      444      471      +27     
==========================================
+ Hits         3170     3215      +45     
- Misses        462      519      +57     
- Partials       13       15       +2     
Impacted Files Coverage Δ
src/components/common/Detail.vue 100.00% <ø> (ø)
src/components/common/EffectiveDateTime.vue 100.00% <ø> (ø)
...omponents/common/PeopleAndRoles/PeopleAndRoles.vue 100.00% <ø> (ø)
src/components/common/YourCompany/index.ts 100.00% <ø> (ø)
src/dialogs/FetchErrorDialog.vue 100.00% <ø> (ø)
src/dialogs/FileAndPayInvalidNameRequestDialog.vue 100.00% <ø> (ø)
src/dialogs/PaymentErrorDialog.vue 100.00% <ø> (ø)
src/dialogs/SaveErrorDialog.vue 100.00% <ø> (ø)
...erfaces/state-interfaces/name-request-interface.ts 100.00% <ø> (ø)
src/resources/LimitedRestorationExtension/BC.ts 100.00% <ø> (ø)
... and 89 more

... and 2 files with indirect coverage changes

severinbeauvais commented 1 year ago

I'm going to merge this now, but don't hesitate to add any extra review comments -- I will see them and create another PR if needed.