bcgov / business-edit-ui

BC Registry Services - Legal Entities - Edit Incorporation Application (correction, alteration)
Apache License 2.0
3 stars 44 forks source link

15475 - Special Resolution UX fixes #503

Closed seeker25 closed 1 year ago

seeker25 commented 1 year ago

Issue #: /bcgov/entity#15474

Description of changes: https://preview.uxpin.com/53053d7aeb85fb29915f7afa596429aea4f2a964#/pages/162999485/simulate/sitemap

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

codecov[bot] commented 1 year ago

Codecov Report

Merging #503 (f759fa0) into main (ae09408) will decrease coverage by 1.21%. The diff coverage is 82.75%.

@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
- Coverage   86.96%   85.76%   -1.21%     
==========================================
  Files         195      202       +7     
  Lines        3645     3750     +105     
  Branches      444      471      +27     
==========================================
+ Hits         3170     3216      +46     
- Misses        462      519      +57     
- Partials       13       15       +2     
Impacted Files Coverage Δ
src/components/common/Detail.vue 100.00% <ø> (ø)
src/components/common/EffectiveDateTime.vue 100.00% <ø> (ø)
...omponents/common/PeopleAndRoles/PeopleAndRoles.vue 100.00% <ø> (ø)
src/components/common/YourCompany/index.ts 100.00% <ø> (ø)
src/dialogs/FetchErrorDialog.vue 100.00% <ø> (ø)
src/dialogs/FileAndPayInvalidNameRequestDialog.vue 100.00% <ø> (ø)
src/dialogs/PaymentErrorDialog.vue 100.00% <ø> (ø)
src/dialogs/SaveErrorDialog.vue 100.00% <ø> (ø)
...erfaces/state-interfaces/name-request-interface.ts 100.00% <ø> (ø)
src/resources/LimitedRestorationExtension/BC.ts 100.00% <ø> (ø)
... and 89 more

... and 2 files with indirect coverage changes

severinbeauvais commented 1 year ago

I'm out of the office this week. Let me know if you really, really need me anyways.

seeker25 commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://business-edit-dev--pr-503-wzv5b0u9.web.app