Closed pwei1018 closed 1 year ago
severinbeauvais
commented
1 year ago Why do these changes look different from Create UI? https://github.com/bcgov/business-create-ui/pull/553
I think what you've done is deleted .github/workflows/cd-firebase.yml here and updated .github/workflows/cd.yml instead.
Meanwhile, in Create UI, you updated .github/workflows/cd-firebase.yml and deleted .github/workflows/cd.yml.
Could you please make this consistent across projects? Thanks.
pwei1018
commented
1 year ago Why do these changes look different from Create UI? bcgov/business-create-ui#553
I think what you've done is deleted .github/workflows/cd-firebase.yml here and updated .github/workflows/cd.yml instead.
Meanwhile, in Create UI, you updated .github/workflows/cd-firebase.yml and deleted .github/workflows/cd.yml.
Could you please make this consistent across projects? Thanks.
done.
severinbeauvais
commented
1 year ago Why do these changes look different from Create UI? bcgov/business-create-ui#553 I think what you've done is deleted .github/workflows/cd-firebase.yml here and updated .github/workflows/cd.yml instead. Meanwhile, in Create UI, you updated .github/workflows/cd-firebase.yml and deleted .github/workflows/cd.yml. Could you please make this consistent across projects? Thanks.
done.
~Filings UI and Edit UI look the same -- good -- but Create UI still looks different. Can you change it?~
OK, sorry, I see you renaming it without a PR. Looks good, thanks.
codecov[bot]
commented
1 year ago Merging #504 (754399e) into main (ae09408) will decrease coverage by
1.21%. The diff coverage is82.75%.
@@ Coverage Diff @@
## main #504 +/- ##
==========================================
- Coverage 86.96% 85.76% -1.21%
==========================================
Files 195 202 +7
Lines 3645 3750 +105
Branches 444 471 +27
==========================================
+ Hits 3170 3216 +46
- Misses 462 519 +57
- Partials 13 15 +2 | Impacted Files | Coverage Δ | |
|---|---|---|
| src/components/common/Detail.vue | 100.00% <ø> (ø) |
|
| src/components/common/EffectiveDateTime.vue | 100.00% <ø> (ø) |
|
| ...omponents/common/PeopleAndRoles/PeopleAndRoles.vue | 100.00% <ø> (ø) |
|
| src/components/common/YourCompany/index.ts | 100.00% <ø> (ø) |
|
| src/dialogs/FetchErrorDialog.vue | 100.00% <ø> (ø) |
|
| src/dialogs/FileAndPayInvalidNameRequestDialog.vue | 100.00% <ø> (ø) |
|
| src/dialogs/PaymentErrorDialog.vue | 100.00% <ø> (ø) |
|
| src/dialogs/SaveErrorDialog.vue | 100.00% <ø> (ø) |
|
| ...erfaces/state-interfaces/name-request-interface.ts | 100.00% <ø> (ø) |
|
| src/resources/LimitedRestorationExtension/BC.ts | 100.00% <ø> (ø) |
|
| ... and 89 more |
Issue #: /bcgov/entity###
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).