bcgov / business-edit-ui

BC Registry Services - Legal Entities - Edit Incorporation Application (correction, alteration)
Apache License 2.0
3 stars 44 forks source link

15951 - Special Resolution Correction - QA / UX fixes #509

Closed seeker25 closed 1 year ago

seeker25 commented 1 year ago

Issue #: /bcgov/entity#15951

Description of changes: Special Resolution Correction - QA / UX fixes

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

codecov[bot] commented 1 year ago

Codecov Report

Merging #509 (84b7d74) into main (ae09408) will increase coverage by 0.05%. The diff coverage is 91.30%.

@@            Coverage Diff             @@
##             main     #509      +/-   ##
==========================================
+ Coverage   86.96%   87.02%   +0.05%     
==========================================
  Files         195      204       +9     
  Lines        3645     3876     +231     
  Branches      444      506      +62     
==========================================
+ Hits         3170     3373     +203     
- Misses        462      489      +27     
- Partials       13       14       +1     
Impacted Files Coverage Δ
src/components/common/EffectiveDateTime.vue 100.00% <ø> (ø)
...omponents/common/PeopleAndRoles/PeopleAndRoles.vue 100.00% <ø> (ø)
src/components/common/YourCompany/index.ts 100.00% <ø> (ø)
src/dialogs/FetchErrorDialog.vue 100.00% <ø> (ø)
src/dialogs/FileAndPayInvalidNameRequestDialog.vue 100.00% <ø> (ø)
src/dialogs/PaymentErrorDialog.vue 100.00% <ø> (ø)
src/dialogs/SaveErrorDialog.vue 100.00% <ø> (ø)
...erfaces/state-interfaces/name-request-interface.ts 100.00% <ø> (ø)
src/resources/LimitedRestorationExtension/BC.ts 100.00% <ø> (ø)
src/resources/LimitedRestorationExtension/BEN.ts 100.00% <ø> (ø)
... and 92 more

... and 2 files with indirect coverage changes

pwei1018 commented 1 year ago

Temporary Url for review: https://business-edit-dev--pr-509-nje1txxx.web.app

seeker25 commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://business-edit-dev--pr-509-nje1txxx.web.app