bcgov / business-edit-ui

BC Registry Services - Legal Entities - Edit Incorporation Application (correction, alteration)
Apache License 2.0
3 stars 44 forks source link

16800 - Alteration - If a Corporation is changing to CCC -> 3 Director Requirement #515

Closed seeker25 closed 1 year ago

seeker25 commented 1 year ago

Issue #: /bcgov/entity#16800

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

codecov[bot] commented 1 year ago

Codecov Report

Merging #515 (bec1164) into main (e481296) will decrease coverage by 0.05%. The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main     #515      +/-   ##
==========================================
- Coverage   87.11%   87.07%   -0.05%     
==========================================
  Files         207      207              
  Lines        3919     3922       +3     
  Branches      510      510              
==========================================
+ Hits         3414     3415       +1     
- Misses        491      493       +2     
  Partials       14       14              
Impacted Files Coverage Δ
src/store/store.ts 82.68% <0.00%> (-0.23%) :arrow_down:
...mponents/common/YourCompany/ChangeBusinessType.vue 100.00% <100.00%> (ø)
Jxio commented 1 year ago

looks good to me! maybe wait until https://github.com/bcgov/business-edit-ui/pull/516 get merged.