Closed Jxio closed 1 year ago
Merging #516 (e481296) into main (ae09408) will increase coverage by
0.14%
. The diff coverage is91.54%
.
@@ Coverage Diff @@
## main #516 +/- ##
==========================================
+ Coverage 86.96% 87.11% +0.14%
==========================================
Files 195 207 +12
Lines 3645 3919 +274
Branches 444 510 +66
==========================================
+ Hits 3170 3414 +244
- Misses 462 491 +29
- Partials 13 14 +1
Impacted Files | Coverage Δ | |
---|---|---|
src/components/common/EffectiveDateTime.vue | 100.00% <ø> (ø) |
|
...omponents/common/PeopleAndRoles/PeopleAndRoles.vue | 100.00% <ø> (ø) |
|
src/components/common/YourCompany/index.ts | 100.00% <ø> (ø) |
|
src/dialogs/FetchErrorDialog.vue | 100.00% <ø> (ø) |
|
src/dialogs/FileAndPayInvalidNameRequestDialog.vue | 100.00% <ø> (ø) |
|
src/dialogs/PaymentErrorDialog.vue | 100.00% <ø> (ø) |
|
src/dialogs/SaveErrorDialog.vue | 100.00% <ø> (ø) |
|
...erfaces/state-interfaces/name-request-interface.ts | 100.00% <ø> (ø) |
|
src/resources/LimitedRestorationExtension/BC.ts | 100.00% <ø> (ø) |
|
src/resources/LimitedRestorationExtension/BEN.ts | 100.00% <ø> (ø) |
|
... and 99 more |
Package + package-lock need to be updated.
Looks pretty good to me, nice job.
As discussed, we need to move the mixin to a util hopefully.
/gcbrun
Temporary Url for review: https://business-edit-dev--pr-516-37q7zf1c.web.app
In the future, please wait for a couple of approvals before merging. Thanks!
In the future, please wait for a couple of approvals before merging. Thanks!
ok will do it next time.
Issue #: /bcgov/entity16572
Description of changes:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).