bcgov / business-edit-ui

BC Registry Services - Legal Entities - Edit Incorporation Application (correction, alteration)
Apache License 2.0
3 stars 44 forks source link

17178 - Alteration - Feature flag - Change Business Types #520

Closed seeker25 closed 1 year ago

seeker25 commented 1 year ago

Issue #: /bcgov/entity#17178

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

seeker25 commented 1 year ago

Controls the options and hides this button, if the business type isn't in the list:

BEN and BC currently enabled on LD for TEST/PROD - all 4 options enabled in DEV, BEN, BC, CC, ULC

image

codecov[bot] commented 1 year ago

Codecov Report

Merging #520 (3ee4d85) into main (e481296) will decrease coverage by 0.07%. Report is 3 commits behind head on main. The diff coverage is 60.00%.

:exclamation: Current head 3ee4d85 differs from pull request most recent head 2e2ce3d. Consider uploading reports for the commit 2e2ce3d to get more accurate results

@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
- Coverage   87.11%   87.04%   -0.07%     
==========================================
  Files         207      207              
  Lines        3919     3922       +3     
  Branches      510      510              
==========================================
  Hits         3414     3414              
- Misses        491      494       +3     
  Partials       14       14              
Files Changed Coverage Δ
src/store/store.ts 82.68% <0.00%> (-0.23%) :arrow_down:
...mponents/common/YourCompany/ChangeBusinessType.vue 100.00% <100.00%> (ø)
src/utils/feature-flag-utils.ts 41.17% <100.00%> (-5.89%) :arrow_down:
seeker25 commented 1 year ago

CI is being very slow

image

image