bcgov / business-edit-ui

BC Registry Services - Legal Entities - Edit Incorporation Application (correction, alteration)
Apache License 2.0
3 stars 44 forks source link

17186 - UXA for alterations + Fixes #522

Closed Jxio closed 1 year ago

Jxio commented 1 year ago

Issue #: /bcgov/entity17186

Description of changes: overall UX check for alteration flow - changing business types

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

codecov[bot] commented 1 year ago

Codecov Report

Merging #522 (d82a8b2) into main (e481296) will increase coverage by 0.04%. Report is 7 commits behind head on main. The diff coverage is 97.95%.

@@            Coverage Diff             @@
##             main     #522      +/-   ##
==========================================
+ Coverage   87.11%   87.15%   +0.04%     
==========================================
  Files         207      209       +2     
  Lines        3919     3955      +36     
  Branches      510      511       +1     
==========================================
+ Hits         3414     3447      +33     
- Misses        491      494       +3     
  Partials       14       14              
Files Changed Coverage Δ
src/components/Alteration/BcRegEntityDetails.vue 100.00% <ø> (ø)
src/components/Alteration/HelpSectionToggle.vue 100.00% <ø> (ø)
...erfaces/state-interfaces/name-request-interface.ts 100.00% <ø> (ø)
src/resources/Alteration/BC.ts 100.00% <ø> (ø)
src/resources/SpecialResolution/CP.ts 100.00% <ø> (ø)
src/store/state/state-model.ts 100.00% <ø> (ø)
tests/unit/utils.ts 83.33% <83.33%> (ø)
src/store/store.ts 83.00% <85.71%> (+0.09%) :arrow_up:
src/App.vue 100.00% <100.00%> (ø)
src/components/Alteration/AlterationSummary.vue 100.00% <100.00%> (ø)
... and 50 more
Jxio commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://business-edit-dev--pr-522-7wzripet.web.app

Jxio commented 1 year ago

Thanks for all of your review!

severinbeauvais commented 1 year ago

Are you ready to merge?

Jxio commented 1 year ago

Are you ready to merge?

yes it's ready to merge