16490 Replaced v-sanitize with vue-sanitize-directive

bcgov / business-edit-ui

BC Registry Services - Legal Entities - Edit Incorporation Application (correction, alteration)

Apache License 2.0

3 stars 44 forks source link

16490 Replaced v-sanitize with vue-sanitize-directive #543

Closed severinbeauvais closed 1 year ago

severinbeauvais commented 1 year ago

Issue #: bcgov/entity#16490

Description of changes:

app version = 4.7.7
uninstalled v-sanitize (which is not Vue3-compatible)
installed vue-sanitize-directive (which is)
updated imports
added "basic" option (same as default with old package)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

severinbeauvais commented 1 year ago

The good news is the new directive works the same as the old directive. The bad news is the old directive doesn't work, so I can't really test anything. Thoughts?

severinbeauvais commented 1 year ago

/gcbrun

bcregistry-sre commented 1 year ago

Temporary Url for review: https://business-edit-dev--pr-543-a9koc56c.web.app

SB says, sample old code: https://dev.edit.business.bcregistry.gov.bc.ca/CP1002588/correction/?correction-id=147099 Sample new code: https://business-edit-dev--pr-543-a9koc56c.web.app/CP1002588/correction/?correction-id=147099