20489 Cleanup of Name Request enums, interfaces, etc

[severinbeauvais]

Issue #: bcgov/entity#20489

Description of changes:

These code changes are in preparation for using the shared Name Request mixin and Correct Name components.

• app version = 4.8.0
• imported latest shared interfaces
• imported latest shared mixins
• used "get NR xxx" getters consistently
• misc sorting of references, etc
• updated code to use latest interfaces (property names, etc)
• misc rename methods/properties/events for consistency/clarity
• save "name request legal name" separately from NR object
• cast some variables "as any" to hide (incorrect) IDE warnings
• added some computed properties (local getters)
• replaced local NameRequestStates enum with shared one
• updated misc filing interfaces
• deleted misc unused interfaces
• replaced local NameRequestIF interface with shared one
• changed filingData declaration to fix misc type warnings
• now save original NR + properties needed by Legal API
• now restore original NR data and legal name
• updated name request mixin to be closer to shared one (for eventual replacement)
• updated some typing
• updated some imports to reduce type clashes
• deleted misc unneeded imports
• updated/fixed unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

[severinbeauvais]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://business-edit-dev--pr-568-5qz4zld8.web.app

SB says, try these:

~Note - I'm presently testing with these businesses and will update the filing ids as I go.~ done!

Note - if any of these don't load, it's probably because the draft filing has been filed or deleted. Just go to Filings UI for the subject business and create a new filing, then use the temporary URL with it.

1. Alteration: https://business-edit-dev--pr-568-5qz4zld8.web.app/BC0873992/alteration/?alteration-id=148978
   • try with incorporation number as name
   • try with NR 1982001 (ph: 1234)
2. Change: https://business-edit-dev--pr-568-5qz4zld8.web.app/FM1017608/change/?change-id=148983
   • try with NR 5349457 (ph: 1234)
3. ~Conversion: https://business-edit-dev--pr-568-5qz4zld8.web.app/FM1056109/conversion/?conversion-id=149017~ not applicable
4. Corp Correction: https://business-edit-dev--pr-568-5qz4zld8.web.app/BC0872927/correction/?correction-id=148989
   • try with edited company name
   • try with incorporation number as name
   • try with NR 4655807 (ph: 1234)
5. Coop Correction: https://business-edit-dev--pr-568-5qz4zld8.web.app/CP1002604/correction/?correction-id=148993
   • try with NR 5485673 (ph: 1234)
6. Firm Correction: https://business-edit-dev--pr-568-5qz4zld8.web.app/FM1056309/correction/?correction-id=148998
   • try with NR 1350552 (ph: 1234)
7. Limited Restoration to Full: https://business-edit-dev--pr-568-5qz4zld8.web.app/BC0875874/limitedRestorationToFull?restoration-id=149014
   • try with incorporation number as name
   • try with NR 4943544 (ph: 1234)
8. Special Resolution: https://business-edit-dev--pr-568-5qz4zld8.web.app/CP0001230/special-resolution/?special-resolution-id=149016
   • try with NR 3862274 (ph: 1234)

[severinbeauvais]

OK, I have finished testing everything. I reported a couple of existing bugs along the way. Everything else seems to work at least as well as before.

[JazzarKarim]

Do you want to get rid of this line Sev? You can also import it in OrgPerson directly from shared components repo. https://github.com/severinbeauvais/business-edit-ui/blob/9230dd861af418267237c2dd4bedb01b82a333c0/src/interfaces/index.ts#L20

I think only Filings UI is left for us to do this change as I've done it on Create UI a couple of days ago.

[JazzarKarim]

Temporary Url for review: https://business-edit-dev--pr-568-5qz4zld8.web.app

SB says, try these:

Note - I'm presently testing with these businesses and will update the filing ids as I go.

1. Alteration: https://business-edit-dev--pr-568-5qz4zld8.web.app/BC0873992/alteration/?alteration-id=148978

   • try with incorporation number as name
   • try with NR 1982001 (ph: 1234)

2. Change: https://business-edit-dev--pr-568-5qz4zld8.web.app/FM1017608/change/?change-id=148983

   • try with NR 5349457 (ph: 1234)
3. ~Conversion:~ not applicable

4. Corp Correction: https://business-edit-dev--pr-568-5qz4zld8.web.app/BC0872927/correction/?correction-id=148989

   • try with edited company name
   • try with incorporation number as name
   • try with NR 4655807 (ph: 1234)

5. Coop Correction: https://business-edit-dev--pr-568-5qz4zld8.web.app/CP1002604/correction/?correction-id=148993

   • try with NR 5485673 (ph: 1234)

6. Firm Correction: https://business-edit-dev--pr-568-5qz4zld8.web.app/FM1056309/correction/?correction-id=148998

   • try with NR 1350552 (ph: 1234)

7. Limited Restoration to Full: https://business-edit-dev--pr-568-5qz4zld8.web.app/BC0875874/limitedRestorationToFull?restoration-id=149014

   • try with incorporation number as name
   • try with NR 4943544 (ph: 1234)

8. Special Resolution: https://business-edit-dev--pr-568-5qz4zld8.web.app/CP0001230/special-resolution/?special-resolution-id=149016

   • try with NR 3862274 (ph: 1234)

Thank you so much for these. Those'll be also of super help in my PR after I rebase and start testing my changes on top of yours 😃

[severinbeauvais]

Do you want to get rid of this line Sev? You can also import it in OrgPerson directly from shared components repo. https://github.com/severinbeauvais/business-edit-ui/blob/9230dd861af418267237c2dd4bedb01b82a333c0/src/interfaces/index.ts#L20

I think only Filings UI is left for us to do this change as I've done it on Create UI a couple of days ago.

Yup. Done.