20779 Implemented Easy Legal Name Fix

bcgov / business-edit-ui

BC Registry Services - Legal Entities - Edit Incorporation Application (correction, alteration)

Apache License 2.0

3 stars 44 forks source link

20779 Implemented Easy Legal Name Fix #570

Closed JazzarKarim closed 6 months ago

JazzarKarim commented 6 months ago

Issue #: /bcgov/entity#20779

Description of changes:

Synced code from the feature branch to main
Implemented the Easy legal name fix
Implemented with feature flag
Lots of misc. fixes that I brought from the legal name branch to here
Fixed/updated unit tests
Brought in the vitest wrapper factory

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

JazzarKarim commented 6 months ago

/gcbrun

bcregistry-sre commented 6 months ago

Temporary Url for review: https://business-edit-dev--pr-570-2rdpwi3s.web.app

Please try https://business-edit-dev--pr-570-2rdpwi3s.web.app/BC0876459/alteration/?alteration-id=148982 (BEN)

https://business-edit-dev--pr-570-2rdpwi3s.web.app/FM1072274/change/?change-id=148985 (SP)

severinbeauvais commented 6 months ago

As I have a PR that I've been working on for a couple of weeks (!) and am final-testing, I'd really appreciate if my PR could go first and then you could apply your changes on top. Is that OK?

JazzarKarim commented 6 months ago

As I have a PR that I've been working on for a couple of weeks (!) and am final-testing, I'd really appreciate if my PR could go first and then you could apply your changes on top. Is that OK?

Absolutely, I wanted to mention this to you. Some of it also overlaps with what I have here. So, you can merge yours first and then I'll rebase. No problem!

JazzarKarim commented 6 months ago

/gcbrun

bcregistry-sre commented 6 months ago

Temporary Url for review: https://business-edit-dev--pr-570-2rdpwi3s.web.app

KJ says, please try: Alteration: https://business-edit-dev--pr-570-2rdpwi3s.web.app/BC0873992/alteration/?alteration-id=148978 Change: https://business-edit-dev--pr-570-2rdpwi3s.web.app/FM1017608/change/?change-id=148983 Corp Correction: https://business-edit-dev--pr-570-2rdpwi3s.web.app/BC0872927/correction/?correction-id=148989 Coop Correction: https://business-edit-dev--pr-570-2rdpwi3s.web.app/CP1002604/correction/?correction-id=148993 Firm Correction: https://business-edit-dev--pr-570-2rdpwi3s.web.app/FM1056309/correction/?correction-id=148998 Limited Restoration to Full: https://business-edit-dev--pr-570-2rdpwi3s.web.app/BC0875874/limitedRestorationToFull?restoration-id=149014 Special Resolution: https://business-edit-dev--pr-570-2rdpwi3s.web.app/CP0001230/special-resolution/?special-resolution-id=149016