23092 - Cont in Business Only Alter to Cont in Type

[ArwenQin]

Issue #: /bcgov/entity#23092

Description of changes:

• A C company can alter to a C Type (Cont In ULC, C, CCC, BEN)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the bcrs-entities-create-ui license (Apache 2.0).

[ArwenQin]

/gcbrun

[ArwenQin]

Now a Cont in business can alter to other valid Cont in legal types successfully. Test with: Cont In ULC to Cont In Benefit or Limited https://business-edit-dev--pr-590-mkdch8go.web.app/C9900774/alteration?accountid=3040

Cont In Limited to Cont In BEN, ULC, or CCC https://business-edit-dev--pr-590-mkdch8go.web.app/C9900734/alteration?accountid=3040

[severinbeauvais]

I cannot test the preview links because Auth API is not returning settings or authorizations.

[ArwenQin]

I cannot test the preview links because Auth API is not returning settings or authorizations.

Oh yes I see... I tried, not working either

[severinbeauvais]

I cannot test the preview links because Auth API is not returning settings or authorizations.

Oh yes I see... I tried, not working either

I will checkout your code and try it locally. (gh pr checkout 590)

[severinbeauvais]

OK, I tested locally the first business (C9900774) and the filing JSON looks correct (see below), but I still think there may be an easier solution.

[ArwenQin]

OK, I tested locally the first business (C9900774) and the filing JSON looks correct (see below), but I still think there may be an easier solution.

Hi Sev, I just updated the solution. I also corrected the entityTypeOptions property for C, CBEN and CUL

[severinbeauvais]

Hi Sev, I just updated the solution. I also corrected the entityTypeOptions property for C, CBEN and CUL

OK, this "feels like" the solution I was expecting.

However, I have a done a bit of testing and there are issues (though maybe not caused by this code)...

1. C9900774 is, at the moment, of type "C". But if try to create a name-change NR for it, business search (from Namerequest UI) says it's type CUL. Please check with Vysakh whether this should have been synced.

2. Here is the draft alteration filing (where I changed type from C to CBEN). Do you know if filing.alteration.nameRequest.legalType should also be CBEN? (Maybe ask Vysakh again.)

Please test thoroughly, including with new NR to change the business name. Thanks.

[ArwenQin]

/gcbrun

[ArwenQin]

Thanks Sev. I just updated the comments/order. I will check with Vysakh

[bcregistry-sre]

Temporary Url for review: https://business-edit-dev--pr-590-mkdch8go.web.app

[ArwenQin]

@severinbeauvais I just did thorough tests, the type alter works well. Only the Namerequest type pending Vysakh's confirmation. By the way, I found another bug in the 3. Court Order and Plan of Arrangement section: If I enter the court order number only, and don't check the POA box, there shows no error; but when we file it, there is a schema error. If we don't enter the court order number, or enter court order number & check the box - all good. Just to confirm, what is the requirement? Is court order number only + no check box allowed? Shall I create a new ticket for this?

[severinbeauvais]

Just to confirm, what is the requirement? Is court order number only + no check box allowed? Shall I create a new ticket for this?

It should be possible to enter a court number and not check the POA box. This is probably a simple fix you can do in this ticket. According to the court order schema, effectOfOrder is a string but isn't nullable, so you probably need to remove that property if it's empty.

Please test a ChangeOfRegistration ("firm alteration") filing for the same bug, and fix that, too.

If you really want, you can create a new ticket for this. (And then just work on it today.)

[ArwenQin]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://business-edit-dev--pr-590-mkdch8go.web.app

[severinbeauvais]

/gcbrun