bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 52 forks source link

Package updates + lots of cleanup #503

Closed JazzarKarim closed 1 year ago

JazzarKarim commented 1 year ago

Issue #: /bcgov/entity#16207

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

codecov[bot] commented 1 year ago

Codecov Report

Merging #503 (1f53563) into main (46389cd) will increase coverage by 8.26%. The diff coverage is 97.13%.

@@            Coverage Diff             @@
##             main     #503      +/-   ##
==========================================
+ Coverage   82.88%   91.15%   +8.26%     
==========================================
  Files         109      169      +60     
  Lines        2104     2747     +643     
  Branches      659      301     -358     
==========================================
+ Hits         1744     2504     +760     
+ Misses        360      239     -121     
- Partials        0        4       +4     
Impacted Files Coverage Δ
src/components/Dashboard/TodoList/PaymentPaid.vue 100.00% <ø> (ø)
...c/components/Dashboard/TodoList/PaymentPending.vue 100.00% <ø> (ø)
...ponents/Dashboard/TodoList/PaymentUnsuccessful.vue 100.00% <ø> (ø)
src/mixins/countries-provinces-mixin.ts 55.55% <ø> (ø)
src/mixins/index.ts 100.00% <ø> (ø)
src/resources/business-config.ts 100.00% <ø> (ø)
src/services/legal-services.ts 64.12% <ø> (ø)
src/services/pay-services.ts 85.71% <ø> (ø)
src/stores/authenticationStore.ts 27.27% <ø> (ø)
src/stores/businessStore.ts 94.82% <ø> (ø)
... and 139 more

... and 1 file with indirect coverage changes

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

JazzarKarim commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://business-filings-dev--pr-503-8u5hy650.web.app