bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 52 forks source link

Start Continuation Out Filings #510

Closed JazzarKarim closed 1 year ago

JazzarKarim commented 1 year ago

Issue #: /bcgov/entity#16116

Description of changes:

Short Demo:

https://github.com/bcgov/business-filings-ui/assets/122301442/c784b156-d373-4169-9b64-8fa3c5cbdd2b

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

JazzarKarim commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://business-filings-dev--pr-510-vnqgkujl.web.app

severinbeauvais commented 1 year ago

Temporary Url for review: https://business-filings-dev--pr-510-vnqgkujl.web.app

Eg: https://business-filings-dev--pr-510-vnqgkujl.web.app/BC0871406/

(I had a quick peek and it looks nice. The action was grayed out until I filed a consent πŸ‘ )

JazzarKarim commented 1 year ago

Temporary Url for review: https://business-filings-dev--pr-510-vnqgkujl.web.app

Eg: https://business-filings-dev--pr-510-vnqgkujl.web.app/BC0871406/

(I had a quick peek and it looks nice. The action was grayed out until I filed a consent πŸ‘ )

Yup! Just a heads up, I found a Legal API bug and I created a ticket for it. If there are more than one Consent to Continuation Outs, Continuation Out is not being returned as an allowable action.

codecov[bot] commented 1 year ago

Codecov Report

Merging #510 (ae99732) into main (46389cd) will increase coverage by 9.20%. The diff coverage is 97.94%.

@@            Coverage Diff             @@
##             main     #510      +/-   ##
==========================================
+ Coverage   82.88%   92.09%   +9.20%     
==========================================
  Files         109      170      +61     
  Lines        2104     2772     +668     
  Branches      659      303     -356     
==========================================
+ Hits         1744     2553     +809     
+ Misses        360      216     -144     
- Partials        0        3       +3     
Impacted Files Coverage Ξ”
src/components/Dashboard/TodoList/PaymentPaid.vue 100.00% <ΓΈ> (ΓΈ)
...c/components/Dashboard/TodoList/PaymentPending.vue 100.00% <ΓΈ> (ΓΈ)
...ponents/Dashboard/TodoList/PaymentUnsuccessful.vue 100.00% <ΓΈ> (ΓΈ)
src/mixins/countries-provinces-mixin.ts 55.55% <ΓΈ> (ΓΈ)
src/mixins/index.ts 100.00% <ΓΈ> (ΓΈ)
src/resources/business-config.ts 100.00% <ΓΈ> (ΓΈ)
src/services/legal-services.ts 64.12% <ΓΈ> (ΓΈ)
src/services/pay-services.ts 85.71% <ΓΈ> (ΓΈ)
src/stores/authenticationStore.ts 27.27% <ΓΈ> (ΓΈ)
src/stores/businessStore.ts 94.82% <ΓΈ> (ΓΈ)
... and 140 more

... and 1 file with indirect coverage changes

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
41.2% 41.2% Duplication

JazzarKarim commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://business-filings-dev--pr-510-vnqgkujl.web.app