16344 Fix pending consent ledger item blurb

[leodube-aot]

Issue #: /bcgov/entity#16344

Description of changes:

• Ensure that the filing object is not pending before showing the item details. If it is pending or it does not contain a data object, use the default template.

Reproducing the issue manually in the code:

1. Add the following code into the getFilings return filter in the file filingHistoryListStore.ts:

   filing.status = FilingStatus.PENDING
   delete filing.data

2. Make sure isStatusPaid in the file FilingTemplate.vue always returns true.

3. Expand the details on the web app.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

[severinbeauvais]

Is it the same fix for 16376? If you can fix that and also test it then let's do it at the same time. (I'll take any heat if you do it even though Dave didn't prioritize it.)

[leodube-aot]

Is it the same fix for 16376? If you can fix that and also test it then let's do it at the same time. (I'll take any heat in doing it even though Dave didn't prioritize it.)

At a glance it appears to be the same, or similar enough issue. Looks like it's not related to a missing data object but to other properties that are not included in the filing object for that given status, so it defaults to [unknown]. I can fix and test that one as well.

[codecov[bot]]

Codecov Report

Merging #513 (36ef10b) into main (46389cd) will increase coverage by 9.20%. The diff coverage is 97.94%.

@@            Coverage Diff             @@
##             main     #513      +/-   ##
==========================================
+ Coverage   82.88%   92.09%   +9.20%     
==========================================
  Files         109      170      +61     
  Lines        2104     2772     +668     
  Branches      659      303     -356     
==========================================
+ Hits         1744     2553     +809     
+ Misses        360      216     -144     
- Partials        0        3       +3     

Impacted Files	Coverage Δ
src/components/Dashboard/TodoList/PaymentPaid.vue	100.00% <ø> (ø)
...c/components/Dashboard/TodoList/PaymentPending.vue	100.00% <ø> (ø)
...ponents/Dashboard/TodoList/PaymentUnsuccessful.vue	100.00% <ø> (ø)
src/mixins/countries-provinces-mixin.ts	55.55% <ø> (ø)
src/mixins/index.ts	100.00% <ø> (ø)
src/resources/business-config.ts	100.00% <ø> (ø)
src/services/legal-services.ts	64.12% <ø> (ø)
src/services/pay-services.ts	85.71% <ø> (ø)
src/stores/authenticationStore.ts	27.27% <ø> (ø)
src/stores/businessStore.ts	94.82% <ø> (ø)
... and 140 more

... and 1 file with indirect coverage changes

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication