bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 52 forks source link

16376 Fix pending limited restoration blurb #518

Closed leodube-aot closed 1 year ago

leodube-aot commented 1 year ago

Issue #: /bcgov/entity#16376

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

codecov[bot] commented 1 year ago

Codecov Report

Merging #518 (6bc0dae) into main (46389cd) will increase coverage by 9.69%. The diff coverage is 97.97%.

@@            Coverage Diff             @@
##             main     #518      +/-   ##
==========================================
+ Coverage   82.88%   92.58%   +9.69%     
==========================================
  Files         109      171      +62     
  Lines        2104     2790     +686     
  Branches      659      306     -353     
==========================================
+ Hits         1744     2583     +839     
+ Misses        360      206     -154     
- Partials        0        1       +1     
Impacted Files Coverage Δ
src/components/Dashboard/TodoList/PaymentPaid.vue 100.00% <ø> (ø)
...c/components/Dashboard/TodoList/PaymentPending.vue 100.00% <ø> (ø)
...ponents/Dashboard/TodoList/PaymentUnsuccessful.vue 100.00% <ø> (ø)
src/mixins/countries-provinces-mixin.ts 100.00% <ø> (+44.44%) :arrow_up:
src/mixins/index.ts 100.00% <ø> (ø)
src/resources/business-config.ts 100.00% <ø> (ø)
src/services/legal-services.ts 64.12% <ø> (ø)
src/services/pay-services.ts 85.71% <ø> (ø)
src/stores/authenticationStore.ts 27.27% <ø> (ø)
src/stores/businessStore.ts 94.82% <ø> (ø)
... and 141 more

... and 1 file with indirect coverage changes

leodube-aot commented 1 year ago

LGTM.

Were you able to test this?

Remember to update the app version and commit those 2 files, too.

Yeah I was able to test it similarly to the last ticket I worked on.

I'll update the app version and commit the 2 files (I keep forgetting haha)

severinbeauvais commented 1 year ago

Looks like this needs to be rebased, please.

leodube-aot commented 1 year ago

Looks like this needs to be rebased, please.

I may need a hand with the rebase since I can't seem to get it to work.

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication