bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 52 forks source link

Implemented the Continuation Out Filing #520

Closed JazzarKarim closed 1 year ago

JazzarKarim commented 1 year ago

Issue #: /bcgov/entity#16117 and /bcgov/entity#16253

Description of changes:

Feel free to test all the components in the temporarily URL!

Continuation Out: screenshot (3)

Ledger Entry for Continuation Out: Continuation Out Done

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

codecov[bot] commented 1 year ago

Codecov Report

Merging #520 (90ad3be) into main (1ac27d5) will increase coverage by 0.21%. The diff coverage is 98.03%.

@@            Coverage Diff             @@
##             main     #520      +/-   ##
==========================================
+ Coverage   92.44%   92.66%   +0.21%     
==========================================
  Files         171      174       +3     
  Lines        2793     2834      +41     
  Branches      309      314       +5     
==========================================
+ Hits         2582     2626      +44     
+ Misses        210      207       -3     
  Partials        1        1              
Impacted Files Coverage Δ
...ents/Dashboard/FilingHistoryList/HeaderActions.vue 100.00% <ø> (ø)
src/components/EntityInfo.vue 100.00% <ø> (ø)
src/components/EntityInfo/EntityMenu.vue 100.00% <ø> (ø)
src/resources/business-config.ts 100.00% <ø> (ø)
src/views/ConsentContinuationOut.vue 100.00% <ø> (ø)
src/views/Correction.vue 100.00% <ø> (ø)
src/stores/rootStore.ts 91.02% <66.66%> (ø)
...oard/FilingHistoryList/filings/ContinuationOut.vue 100.00% <100.00%> (ø)
...nents/Dashboard/FilingHistoryList/filings/index.ts 100.00% <100.00%> (ø)
src/components/EntityInfo/EntityHeader.vue 100.00% <100.00%> (ø)
... and 7 more

... and 2 files with indirect coverage changes

JazzarKarim commented 1 year ago

/gcbrun

pwei1018 commented 1 year ago

Temporary Url for review: https://business-filings-dev--pr-520-ns22j1ov.web.app

severinbeauvais commented 1 year ago

Temporary Url for review: https://business-filings-dev--pr-520-ns22j1ov.web.app

Eg, https://business-filings-dev--pr-520-ns22j1ov.web.app/BC0871322

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
4.0% 4.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint