search

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 52 forks source link

16761 Completing Party email address needs to be editable for end-user #524

Closed chenhongjing closed 1 year ago

chenhongjing commented 1 year ago

Issue #: /bcgov/entity#16761

Description of changes: Before: image

After: image

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.5% 3.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

chenhongjing commented 1 year ago

Please let me know if there is something I forgot to consider. It's just a very small modification. :sweat_smile:

codecov[bot] commented 1 year ago

Codecov Report

Merging #524 (8d834a2) into main (1ac27d5) will increase coverage by 0.21%. The diff coverage is 98.03%.

@@            Coverage Diff             @@
##             main     #524      +/-   ##
==========================================
+ Coverage   92.44%   92.66%   +0.21%     
==========================================
  Files         171      174       +3     
  Lines        2793     2834      +41     
  Branches      309      314       +5     
==========================================
+ Hits         2582     2626      +44     
+ Misses        210      207       -3     
  Partials        1        1
Impacted Files Coverage Δ
...ents/Dashboard/FilingHistoryList/HeaderActions.vue 100.00% <ø> (ø)
src/components/EntityInfo.vue 100.00% <ø> (ø)
src/components/EntityInfo/EntityMenu.vue 100.00% <ø> (ø)
src/resources/business-config.ts 100.00% <ø> (ø)
src/views/ConsentContinuationOut.vue 100.00% <ø> (ø)
src/views/Correction.vue 100.00% <ø> (ø)
src/stores/rootStore.ts 91.02% <66.66%> (ø)
...oard/FilingHistoryList/filings/ContinuationOut.vue 100.00% <100.00%> (ø)
...nents/Dashboard/FilingHistoryList/filings/index.ts 100.00% <100.00%> (ø)
src/components/EntityInfo/EntityHeader.vue 100.00% <100.00%> (ø)
... and 7 more

... and 2 files with indirect coverage changes

severinbeauvais commented 1 year ago

I think @bennypc and @leodube-aot should have a quick look to see the change in passing a static prop instead of a dynamic one.