search

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 52 forks source link

17108 fixed invalid variable #530

Closed severinbeauvais closed 1 year ago

severinbeauvais commented 1 year ago

Issue #: bcgov/entity#17108

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

codecov[bot] commented 1 year ago

Codecov Report

Merging #530 (b9e6724) into main (1ac27d5) will increase coverage by 0.22%. The diff coverage is 98.11%.

@@            Coverage Diff             @@
##             main     #530      +/-   ##
==========================================
+ Coverage   92.44%   92.67%   +0.22%     
==========================================
  Files         171      174       +3     
  Lines        2793     2838      +45     
  Branches      309      314       +5     
==========================================
+ Hits         2582     2630      +48     
+ Misses        210      207       -3     
  Partials        1        1
Impacted Files Coverage Δ
src/App.vue 100.00% <ø> (ø)
src/components/AnnualReport/AGMDate.vue 100.00% <ø> (ø)
src/components/AnnualReport/ARDate.vue 100.00% <ø> (ø)
src/components/Dashboard/AddressListSm.vue 100.00% <ø> (ø)
.../components/Dashboard/Alerts/FrozenInformation.vue 100.00% <ø> (ø)
...components/Dashboard/Alerts/MissingInformation.vue 100.00% <ø> (ø)
...rc/components/Dashboard/Alerts/NotInCompliance.vue 100.00% <ø> (ø)
.../components/Dashboard/Alerts/NotInGoodStanding.vue 100.00% <ø> (ø)
src/components/Dashboard/CustodianListSm.vue 100.00% <ø> (ø)
src/components/Dashboard/DirectorListSm.vue 100.00% <ø> (ø)
... and 98 more

... and 1 file with indirect coverage changes

pwei1018 commented 1 year ago

Temporary Url for review: https://business-filings-dev--pr-530-g87isukl.web.app

severinbeauvais commented 1 year ago

That was easy, LGTM!

Hah, yes, and if we had typed this properly, it would have been caught earlier!