bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 52 forks source link

16364 Changed store actions type #536

Closed bennypc closed 1 year ago

bennypc commented 1 year ago

Issue #: /bcgov/entity#16364

Description of changes: Changed action store type to match new requirements

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

codecov[bot] commented 1 year ago

Codecov Report

Merging #536 (d7db5c1) into main (1ac27d5) will increase coverage by 0.07%. Report is 14 commits behind head on main. The diff coverage is 94.55%.

:exclamation: Current head d7db5c1 differs from pull request most recent head 5182ee4. Consider uploading reports for the commit 5182ee4 to get more accurate results

@@            Coverage Diff             @@
##             main     #536      +/-   ##
==========================================
+ Coverage   92.44%   92.52%   +0.07%     
==========================================
  Files         171      176       +5     
  Lines        2793     2863      +70     
  Branches      309      315       +6     
==========================================
+ Hits         2582     2649      +67     
- Misses        210      213       +3     
  Partials        1        1              
Files Changed Coverage Δ
src/App.vue 100.00% <ø> (ø)
src/components/AnnualReport/AGMDate.vue 100.00% <ø> (ø)
src/components/AnnualReport/ARDate.vue 100.00% <ø> (ø)
src/components/Dashboard/AddressListSm.vue 100.00% <ø> (ø)
.../components/Dashboard/Alerts/FrozenInformation.vue 100.00% <ø> (ø)
...components/Dashboard/Alerts/MissingInformation.vue 100.00% <ø> (ø)
...rc/components/Dashboard/Alerts/NotInCompliance.vue 100.00% <ø> (ø)
.../components/Dashboard/Alerts/NotInGoodStanding.vue 100.00% <ø> (ø)
src/components/Dashboard/CustodianListSm.vue 100.00% <ø> (ø)
src/components/Dashboard/DirectorListSm.vue 100.00% <ø> (ø)
... and 101 more

... and 1 file with indirect coverage changes

ChrisGabel23 commented 1 year ago

When I did a similar ticket for Create-UI, there was a file with the action interfaces that was no longer needed. I don't see that file being deleted here: src/interfaces/action-interface.ts

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication