bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 51 forks source link

11436 + 17937 - Framework for AGM Extension and AGM Location Change filings #547

Closed severinbeauvais closed 11 months ago

severinbeauvais commented 11 months ago

Issue #: bcgov/entity#11436 and bcgov/entity#17937

Please note that the code duplication is inevitable until we refactor all local filings into a common template + slots (which will be a lot of work and is not planned atm).

Description of changes:

Commit 1:

Commit 2:

Commit 3:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

bcregistry-sre commented 11 months ago

Temporary Url for review: https://business-filings-dev--pr-547-f6vodu71.web.app

SB says, try this business: https://business-filings-dev--pr-547-f6vodu71.web.app/BC0871407/

tshyun24 commented 11 months ago

Looks good to me also👏

sonarcloud[bot] commented 11 months ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 6 Code Smells

No Coverage information No Coverage information
31.8% 31.8% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

severinbeauvais commented 11 months ago

/gcbrun

bcregistry-sre commented 11 months ago

Temporary Url for review: https://business-filings-dev--pr-547-f6vodu71.web.app