18027 AGM Location change

ketaki-deodhar commented 11 months ago

Issue #: /bcgov/entity#18027

Description of changes:

change FF from enable-agm-location-chg to supported-agm-location-chg-entities
enable allowable actions check (remove debugging)
update menu tooltip
complete sections
update fee codes (AGMLC)
remove save/resume - Yes
update validation
implement unit tests
add help content

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

ketaki-deodhar commented 11 months ago

/gcbrun

bcregistry-sre commented 11 months ago

Temporary Url for review: https://business-filings-dev--pr-551-d62ou6sp.web.app

severinbeauvais commented 11 months ago

Please fix broken unit tests.

ketaki-deodhar commented 11 months ago

I used the Canada Post lookup to fill in a BC address, and it validated successfully (even though it's invalid).

Actually, don't worry about this one, because the next ticket will change this to a text input, I think.

Yes this will change

ketaki-deodhar commented 11 months ago

There's something wrong with the fee handling. This is what I got after I clicked File Now and then No Fee:

I tried ONLY AGM location change application. I did not see the fee dialog as in this screenshot. There is a 6-month consent to continue out in your cart as well. I will test similar scenario and see what is happening

https://github.com/bcgov/business-filings-ui/assets/116035339/54eed25b-020e-47f5-aa42-1b156ddc4d6e

ketaki-deodhar commented 11 months ago

The AGM Year input shouldn't validate until I leave it (blur) or click the File Now button.

Here, I only just started entering the year:

Still looking into this. Not included in this commit

ketaki-deodhar commented 11 months ago

/gcbrun

bcregistry-sre commented 11 months ago

Temporary Url for review: https://business-filings-dev--pr-551-d62ou6sp.web.app

ketaki-deodhar commented 11 months ago

The red border is on the wrong div (should be left-most, like Certify).

Updated:

severinbeauvais commented 11 months ago

I tried ONLY AGM location change application. I did not see the fee dialog as in this screenshot. There is a 6-month consent to continue out in your cart as well. I will test similar scenario and see what is happening

Thanks for the video. Please try this filing while logged in as staff (IDIR).

severinbeauvais commented 11 months ago

Example:

~The entire AGM Year div (row) should have the red border. Also, the top-left border should not have a radius.~ now fixed
Don't worry about the address red border, since this will be replaced in the next ticket.

ketaki-deodhar commented 11 months ago

/gcbrun

bcregistry-sre commented 11 months ago

Temporary Url for review: https://business-filings-dev--pr-551-d62ou6sp.web.app

ketaki-deodhar commented 11 months ago

I tried ONLY AGM location change application. I did not see the fee dialog as in this screenshot. There is a 6-month consent to continue out in your cart as well. I will test similar scenario and see what is happening

Thanks for the video. Please try this filing while logged in as staff (IDIR).

Yes you are right. When logged in as staff 'Staff Payment' dialog is displayed.

severinbeauvais commented 11 months ago

I tried ONLY AGM location change application. I did not see the fee dialog as in this screenshot. There is a 6-month consent to continue out in your cart as well. I will test similar scenario and see what is happening

Thanks for the video. Please try this filing while logged in as staff (IDIR).

Yes you are right. When logged in as staff 'Staff Payment' dialog is displayed.

~When logged in as staff, do you see the additional "consent to continue out" fee code?~ is now fixed

ketaki-deodhar commented 11 months ago

I tried ONLY AGM location change application. I did not see the fee dialog as in this screenshot. There is a 6-month consent to continue out in your cart as well. I will test similar scenario and see what is happening

Thanks for the video. Please try this filing while logged in as staff (IDIR).

Yes you are right. When logged in as staff 'Staff Payment' dialog is displayed.

When logged in as staff, do you see the additional "consent to continue out" fee code?

No. This is how it is

severinbeauvais commented 11 months ago

When logged in as staff, do you see the additional "consent to continue out" fee code?

No. This is how it is

~Try it again and select "No Fee" (or the other options). There's still something wrong there.~ now fixed

ketaki-deodhar commented 11 months ago

When logged in as staff, do you see the additional "consent to continue out" fee code?

No. This is how it is

Try it again and select "No Fee" (or the other options). There's still something wrong there.

found the issue and fixed it.

ketaki-deodhar commented 11 months ago

/gcbrun

bcregistry-sre commented 11 months ago

Temporary Url for review: https://business-filings-dev--pr-551-d62ou6sp.web.app

bcregistry-sre commented 11 months ago

Temporary Url for review: https://business-filings-dev--pr-551-d62ou6sp.web.app

JazzarKarim commented 11 months ago

~Ketaki, I was trying to see if I can press on the button when I'm in a ULC (ULC is not in the FF), this is what I got:~ ULC AGMCHG

~I was wondering if this the correct behavior that we want. Maybe we shouldn't see the button (the list will have 3 buttons) instead? Maybe the design folks have an answer.~

Never mind, I just saw your comment above. Sorry about that.

ketaki-deodhar commented 11 months ago

~Ketaki, I was trying to see if I can press on the button when I'm in a ULC (ULC is not in the FF), this is what I got:~

~I was wondering if this the correct behavior that we want. Maybe we shouldn't see the button (the list will have 3 buttons) instead? Maybe the design folks have an answer.~

Never mind, I just saw your comment above. Sorry about that.