AGM Location Change First PR

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings

Apache License 2.0

9 stars 51 forks source link

AGM Location Change First PR #553

Closed JazzarKarim closed 11 months ago

JazzarKarim commented 11 months ago

Issue #: /bcgov/entity#18161

Description of changes:

Updated Help Text
Added the reason box with wiring
Fixed validations
Removed address component (to be replaced by another new one in a subsequent PR)
Updated AGM Year rule

Note: In order to help with reviewing and not create one huge PR, I'll be doing the work in multiple small PRs. I'm also merging to a new branch that I created. I will delete this branch immediately after the work is fully done.

I'll update the package version in my last PR.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

severinbeauvais commented 11 months ago

PS This branch won't build with gcbrun because it doesn't follow the naming standard (feature-xxx). But I don't see any issue with merging this to main branch if you want.

JazzarKarim commented 11 months ago

PS This branch won't build with gcbrun because it doesn't follow the naming standard (feature-xxx). But I don't see any issue with merging this to main branch if you want.

You're absolutely right. Should I rename the branch or merge it to main? I guess both would work. I'm not sure, what do you think Sev? What do you prefer?

severinbeauvais commented 11 months ago

You're absolutely right. Should I rename the branch or merge it to main? I guess both would work. I'm not sure, what do you think Sev? What do you prefer?

I'd prefer merging to main, but you'd have to fix the broken unit test(s) first.