Closed JazzarKarim closed 11 months ago
/gcbrun
Temporary Url for review: https://business-filings-dev--pr-554-tkl68fqq.web.app
KJ says, here's a link if you want to test: https://business-filings-dev--pr-554-tkl68fqq.web.app/BC0871486?accountid=3040
Upcoming PR: Unit tests + Update the "Request for AGM Location Change" in To Do in case payment fails? I don't know what I'll do there. I'll see.
Check with Argus on what is needed to re-process the payment if it failed. Probably the user need to "retry payment" (or "change payment type"???).
Kudos, SonarCloud Quality Gate passed!
0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells
No Coverage information
0.0% Duplication
LGTM. Looking forward to next PR :)
PS I'm lovin' the small PRs.
Thanks Sev!
I also really really like them. I think it's always a great idea to go for smaller ones whenever we think a ticket's work is going to be big. It's much easier for the reviewers and the person working on it!
PS: There are two comments above from you Sev. I haven't forgot about them! I'll be dealing with them next PR 😎
Issue #: /bcgov/entity#18161
Description of changes:
Upcoming PR: Unit tests + Update the "Request for AGM Location Change" in To Do in case payment fails? I don't know what I'll do there. I'll see.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).