bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 51 forks source link

AGM Location Change second PR #554

Closed JazzarKarim closed 11 months ago

JazzarKarim commented 11 months ago

Issue #: /bcgov/entity#18161

Description of changes:

Upcoming PR: Unit tests + Update the "Request for AGM Location Change" in To Do in case payment fails? I don't know what I'll do there. I'll see.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

JazzarKarim commented 11 months ago

/gcbrun

bcregistry-sre commented 11 months ago

Temporary Url for review: https://business-filings-dev--pr-554-tkl68fqq.web.app

KJ says, here's a link if you want to test: https://business-filings-dev--pr-554-tkl68fqq.web.app/BC0871486?accountid=3040

severinbeauvais commented 11 months ago

Upcoming PR: Unit tests + Update the "Request for AGM Location Change" in To Do in case payment fails? I don't know what I'll do there. I'll see.

Check with Argus on what is needed to re-process the payment if it failed. Probably the user need to "retry payment" (or "change payment type"???).

sonarcloud[bot] commented 11 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

JazzarKarim commented 11 months ago

LGTM. Looking forward to next PR :)

PS I'm lovin' the small PRs.

Thanks Sev!

I also really really like them. I think it's always a great idea to go for smaller ones whenever we think a ticket's work is going to be big. It's much easier for the reviewers and the person working on it!

PS: There are two comments above from you Sev. I haven't forgot about them! I'll be dealing with them next PR 😎