search

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 51 forks source link

18024 Incremental AGM extension work #558

Closed severinbeauvais closed 10 months ago

severinbeauvais commented 11 months ago

Issue #: bcgov/entity#18024

This is some up-front architecture/layout work as I figure out how to handle the data and logic for this filing.

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

codecov[bot] commented 11 months ago

Codecov Report

Merging #558 (097b876) into main (1ac27d5) will decrease coverage by 92.45%. Report is 34 commits behind head on main. The diff coverage is n/a.

:exclamation: Current head 097b876 differs from pull request most recent head 665c600. Consider uploading reports for the commit 665c600 to get more accurate results

@@            Coverage Diff            @@
##             main   #558       +/-   ##
=========================================
- Coverage   92.44%      0   -92.45%     
=========================================
  Files         171      0      -171     
  Lines        2793      0     -2793     
  Branches      309      0      -309     
=========================================
- Hits         2582      0     -2582     
+ Misses        210      0      -210     
+ Partials        1      0        -1

see 170 files with indirect coverage changes

severinbeauvais commented 10 months ago

If the rest of you could review this, please...

My intent with this was to prepare the layout and architecture of the AGM Extension filings so that the remaining tickets can be done by multiple people. The main thing I wasn't sure about was passing data between the parent component and the sub-components. It turned out to be very easy -- let me know if you want a walk-through.

severinbeauvais commented 10 months ago

If you have previously reviewed this, please look over my last few comments.

If you havent reviewed this yet, please do - thanks :)

severinbeauvais commented 10 months ago

Do not merge until Business Digital Credentials is out of Dev environment.

JazzarKarim commented 10 months ago

Sev, do you want to merge before me? I don't mind doing the rebase if you would like.

severinbeauvais commented 10 months ago

Sev, do you want to merge before me? I don't mind doing the rebase if you would like.

I've made some extra changes on top of what you did. You sure you don't mind rebasing?

JazzarKarim commented 10 months ago

Sev, do you want to merge before me? I don't mind doing the rebase if you would like.

I've made some extra changes on top of what you did. You sure you don't mind rebasing?

Actually Sev, I'm just going to merge mine now. I think it'll be easier for you to rebase than me. Is that OK with you?

severinbeauvais commented 10 months ago

Actually Sev, I'm just going to merge mine now. I think it'll be easier for you to rebase than me. Is that OK with you?

Do it.

severinbeauvais commented 10 months ago

/gcbrun

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

No Coverage information No Coverage information
0.3% 0.3% Duplication

bcregistry-sre commented 10 months ago

Temporary Url for review: https://business-filings-dev--pr-558-eyhk80mt.web.app

SB says, try this: https://business-filings-dev--pr-558-eyhk80mt.web.app/BC0870754/