18284 Updated CSP - Githubissues

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings

Apache License 2.0

9 stars 51 forks source link

18284 Updated CSP #561

Closed severinbeauvais closed 10 months ago

severinbeauvais commented 10 months ago

Issue #: bcgov/entity#18284

Description of changes:

added wss://*.gov.bc.ca to connect-src

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

severinbeauvais commented 10 months ago

The problem doesn't seem to be solved on the preview site (see URL above). Should we NOT merge this PR then?

severinbeauvais commented 10 months ago

I think this CSP change solves nothing. Closing this PR.

severinbeauvais commented 10 months ago

Let's try this fix again...

severinbeauvais commented 10 months ago

/gcbrun

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

bcregistry-sre commented 10 months ago

Temporary Url for review: https://business-filings-dev--pr-561-z125qh31.web.app

SB says, try this: https://business-filings-dev--pr-561-z125qh31.web.app/FM1038931?accountid=2288 (login with BCREG0020)