bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 51 forks source link

Extension Request Scenario 1 #577

Closed JazzarKarim closed 10 months ago

JazzarKarim commented 10 months ago

Issue #: /bcgov/entity#18273

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

JazzarKarim commented 10 months ago

/gcbrun

bcregistry-sre commented 10 months ago

Temporary Url for review: https://business-filings-dev--pr-577-ys4cpon8.web.app

KJ says: https://business-filings-dev--pr-577-ys4cpon8.web.app/BC0871411/

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

JazzarKarim commented 10 months ago

/gcbrun

bcregistry-sre commented 10 months ago

Temporary Url for review: https://business-filings-dev--pr-577-ys4cpon8.web.app

KJ says: https://business-filings-dev--pr-577-ys4cpon8.web.app/BC0871411/

severinbeauvais commented 10 months ago

I still think this PR is acceptable to be merged. Leo/Ketaki, if you agree then please merge it.

Leo, you'll be able to rebase to main and create your own PR for your changes. Good luck. Let me know how I can help!

leodube-aot commented 10 months ago

@severinbeauvais I'll go ahead and merge this so I can rebase onto my branch. I'll have a look over your unresolved comments on this PR to address them for my PR.