search

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 52 forks source link

18273 Extension Request Scenario 2 #580

Closed leodube-aot closed 12 months ago

leodube-aot commented 12 months ago

Issue #: /bcgov/entity#18273

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

leodube-aot commented 12 months ago

/gcbrun

bcregistry-sre commented 12 months ago

Temporary Url for review: https://business-filings-dev--pr-580-nt8l0mqi.web.app

severinbeauvais commented 12 months ago

~Your rebase ate your app version changes. Also, there's 2 new unit test errors.~ this is now fixed, thanks

sonarcloud[bot] commented 12 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

severinbeauvais commented 12 months ago

@severinbeauvais Sev, will you be wiring the alreadyExtended and requestExpired in your get everything together ticket or should it be done in this ticket you think?

I think it should be done in THIS ticket, though not necessarily this PR. My framework ticket doesn't care about the eligibility fields. THIS ticket is what calculates those fields.

JazzarKarim commented 12 months ago

@severinbeauvais Sev, will you be wiring the alreadyExtended and requestExpired in your get everything together ticket or should it be done in this ticket you think?

I think it should be done in THIS ticket, though not necessarily this PR. My framework ticket doesn't care about the eligibility fields. THIS ticket is what calculates those fields.

Makes sense. OK, got it. Then it can be done in a subsequent PR.