18369 changed the duration of extension messages in accordance with U…

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings

Apache License 2.0

9 stars 51 forks source link

18369 changed the duration of extension messages in accordance with U… #582

Closed PaulGarewal closed 10 months ago

PaulGarewal commented 10 months ago

…X design

Issue #: /bcgov/entity#18369

Description of changes:

Changed the messages in the AGM Extension Evaluation Sub-Component in accordance with UX design below:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

JazzarKarim commented 10 months ago

Paul, just one other small issue. The text isn't reactive when we go from one date to anther while staying eligible. Might be worth looking into it.

For example, I went from November 15 to 30 (both eligible):

PaulGarewal commented 10 months ago

/gcbrun

JazzarKarim commented 10 months ago

Paul, just one other small issue. The text isn't reactive when we go from one date to anther while staying eligible. Might be worth looking into it.

Fixed, thanks!

bcregistry-sre commented 10 months ago

Temporary Url for review: https://business-filings-dev--pr-582-bjovr7fb.web.app

sonarcloud[bot] commented 10 months ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication