search

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 52 forks source link

18204 disable restore based on ff #583

Closed jamespaologarcia closed 12 months ago

jamespaologarcia commented 12 months ago

Issue #: /bcgov/entity#18204

Added feature flag

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

PaulGarewal commented 12 months ago

Looks good from what I understand.

Are the tests supposed to fail? I will wait for confirmation/update on the tests before approval.

severinbeauvais commented 12 months ago

Please fix the broken tests. They're probably related to you making the dropdown menu item conditional.

jamespaologarcia commented 12 months ago

/gcbrun

bcregistry-sre commented 12 months ago

Temporary Url for review: https://business-filings-dev--pr-583-qrxozjdm.web.app

severinbeauvais commented 12 months ago

OK with me as long as UI/UX team is OK with displaying the menu option conditionally (which is different from now).

I've heard that they are OK with this.

Note that all 3 restoration filings are now hidden when the business is not historical.

sonarcloud[bot] commented 12 months ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

jamespaologarcia commented 12 months ago

/gcbrun

bcregistry-sre commented 12 months ago

Temporary Url for review: https://business-filings-dev--pr-583-qrxozjdm.web.app