18273+18558 Extension Request Cleanup and Tests

[leodube-aot]

Issue #: /bcgov/entity#18273 and /bcgov/entity#18558

Description of changes:

• Connected alreadyExtended and requestExpired for AgmExtensionEvaluation.vue.
• Implemented extensionRequestValid and emit result to parent component.
• Added evaluateResult flag to only show extension request warning box and duration of extension text field on valid extension request.
• Moved scenario logic into separate functions called from a checkEligibility() function.
• Added unit tests for ExtensionRequest component to cover every scenario.
• Updated unit tests for AgmExtensionEvaluation
• Created unit tests for date-utilities

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

[severinbeauvais]

Update: Date validation, and specific section errors, have been implemented. Looks great, thanks!

This should probably throw an error, I think?

Also this?

OK, when I click File Now, the component shows an error, but I don't know what's incorrect:

[leodube-aot]

@severinbeauvais Yeah you're correct, there should be more clear error handling. I'll get that fixed. The one field I can confirm we don't validate is the Intended AGM date (based on what Mihai has said), but perhaps at should still not allow dates in the past for that one.

[leodube-aot]

Newest changes:

• Fixed bcgov/entity#18558
• Added more validation to the text and date picker components:
  • agmYear cannot be before incorporation date, or in the future. Must also be 4 digits.
  • prevAgmDate cannot be before incorporation date, or in the future.
  • intendedAgmDate cannot be in the past
• Made it so that if the extension request is invalid, the specific section(s) that are invalid show the red border, instead of the entire component.
• Need to fix a couple unit tests still

[leodube-aot]

/gcbrun

[bcregistry-sre]

Temporary Url for review: https://business-filings-dev--pr-585-c2c631r7.web.app

LD says try: https://business-filings-dev--pr-585-c2c631r7.web.app/BC0871200?accountid=668

[severinbeauvais]

~Leo, does this PR complete everything for AGM Extensions? If not, what's left?~ answer is below

[severinbeauvais]

~Leo, should there be a check that the intended AGM date is not later than the due date? Maybe this wouldn't cause a validation error but could display the yellow box with some message. Check with Mihai and Yui.~ answer is below

[leodube-aot]

@severinbeauvais I checked and there is one more formula to be added to the AGM extension calculation bcgov/entity#18579. Otherwise, this ticket has completed all the hooking up required.

For the intended date, Mihai's comment explains why we don't validate it.

[severinbeauvais]

Otherwise, this ticket has completed all the hooking up required.

Yeah, it looks that way -- thank you! But I am still unable to file an AGM extension. Do we know if this is solely an API issue?

[leodube-aot]

Yeah, it looks that way -- thank you! But I am still unable to file an AGM extension. Do we know if this is solely an API issue?

I think it's just an API issue. The saveFiling() function in AgmExtension throws an axios error: "Request failed with status code 422" when "File and Pay" is clicked, which prevents redirection to the payment page.

[sonarcloud[bot]]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication