18534 Amalg unit tests + small fixes + more typing

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings

Apache License 2.0

9 stars 51 forks source link

18534 Amalg unit tests + small fixes + more typing #596

Closed severinbeauvais closed 9 months ago

severinbeauvais commented 9 months ago

Issue #: bcgov/entity#18534

Description of changes:

app version = 7.0.23
enabled strict typing
misc small fixes/cleanup
fixed filed IA blurb
added amalgamation allowable action
added unit tests
added some typing to unit tests

Please ignore SonarCloud "Quality Gate failed" check, which is due to duplicated code (and which we're not going to fix at this time).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

severinbeauvais commented 9 months ago

/gcbrun

bcregistry-sre commented 9 months ago

Temporary Url for review: https://business-filings-dev--pr-596-mf6ghyks.web.app

SB says, try these:

numbered draft AA: https://business-filings-dev--pr-596-mf6ghyks.web.app/T7HKt2pK2z/
named draft AA: https://business-filings-dev--pr-596-mf6ghyks.web.app/Tc2caJYQrz/
new company from IA: https://business-filings-dev--pr-596-mf6ghyks.web.app/BC0871510/
filed IA: https://business-filings-dev--pr-596-mf6ghyks.web.app/TGDqw1C4eD?filing_id=147327

sonarcloud[bot] commented 9 months ago

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
3.3% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint