bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings
Apache License 2.0
9 stars 51 forks source link

Updated Amalgamation Selection in response to UXA notes #602

Closed JazzarKarim closed 9 months ago

JazzarKarim commented 9 months ago

Issue #: /bcgov/entity#18805

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

JazzarKarim commented 9 months ago

/gcbrun

bcregistry-sre commented 9 months ago

Temporary Url for review: https://business-filings-dev--pr-602-o54pzuh0.web.app

KJ says: https://business-filings-dev--pr-602-o54pzuh0.web.app/BC0871512

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1ac27d5) 92.44% compared to head (e162b6f) 0.00%. Report is 70 commits behind head on main.

:exclamation: Current head e162b6f differs from pull request most recent head 56ea820. Consider uploading reports for the commit 56ea820 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #602 +/- ## ========================================= - Coverage 92.44% 0 -92.45% ========================================= Files 171 0 -171 Lines 2793 0 -2793 Branches 309 0 -309 ========================================= - Hits 2582 0 -2582 + Misses 210 0 -210 + Partials 1 0 -1 ``` [see 165 files with indirect coverage changes](https://app.codecov.io/gh/bcgov/business-filings-ui/pull/602/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=bcgov)
sonarcloud[bot] commented 9 months ago

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud