19005 Implemented historical - amalgamation reason text

severinbeauvais commented 8 months ago

Issue #: bcgov/entity#19005

Description of changes:

app version = 7.0.30
updated some code comments
added AmalgamatedInto interface object
added enum mixin and utility functions
added some business store getters
refactored getReasonText() and added case for amalgamation
cast some parameters to pre-empt code errors
added/updated unit tests

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

Note: This cannot be tested "for real" until a business is made historical by an amalgamation. I tested locally using mocked data as per the RFC / ticket. I also wrote some unit tests that verify all cases, so you can check there for the expected output.

severinbeauvais commented 8 months ago

/gcbrun

bcregistry-sre commented 8 months ago

Temporary Url for review: https://business-filings-dev--pr-604-sawoy77i.web.app

SB says, try this; https://business-filings-dev--pr-604-sawoy77i.web.app/BC0870788 (voluntary dissolution)

sonarcloud[bot] commented 8 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
2.3% Duplication on New Code

See analysis details on SonarCloud

bcgov / business-filings-ui

19005 Implemented historical - amalgamation reason text #604

Quality Gate passed