Added amalgamation FF check

bcgov / business-filings-ui

BC Registry Services - Legal Entities - Business Dashboard and Filings

Apache License 2.0

9 stars 52 forks source link

Added amalgamation FF check #610

Closed JazzarKarim closed 9 months ago

JazzarKarim commented 9 months ago

Issue #: bcgov/entity#19201

Description of changes:

Don't display the amalgamate button if the FF doesn't support that entity type

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-filings-ui license (Apache 2.0).

JazzarKarim commented 9 months ago

@severinbeauvais Sev, I just saw your PR. In my case I'm not showing the button altogether based of the FF. I'm guessing we don't want to do that? Shall we proceed with your PR or shall I ask Mihai?

sonarcloud[bot] commented 9 months ago

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

severinbeauvais commented 9 months ago

Can this wait until Thursday's deployment, then? (Not a hotfix?) (Will need to be pushed to Test today, along with its predecessor PRs.)

JazzarKarim commented 9 months ago

Can this wait until Thursday's deployment, then? (Not a hotfix?) (Will need to be pushed to Test today, along with its predecessor PRs.)

It depends on how urgent Mihai wants it. I guess it can wait.